New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(amazon q): display multiple diff patches #5812

Merged

nkomonen-amazon merged 22 commits into aws:master from ntarakad-aws:selective_transform

Nov 20, 2024

Contributor

ntarakad-aws commented Oct 18, 2024

adding functionality for selective transformation to allow for java 17 as source and display multiple diff patches for the user to accept/reject

ntarakad-aws requested review from a team as code owners

October 18, 2024 00:27

ntarakad-aws marked this pull request as draft

October 18, 2024 00:27

ntarakad-aws changed the title ~~allow jdk17 as source, display multiple diff patches~~ feat(qct): allow jdk17 as source, display multiple diff patches

dhasani23 changed the title ~~feat(qct): allow jdk17 as source, display multiple diff patches~~ feat(amazon q): allow jdk17 as source, display multiple diff patches

dhasani23 reviewed

View reviewed changes

package-lock.json Outdated Show resolved Hide resolved

dhasani23 reviewed

View reviewed changes

packages/amazonq/test/unit/amazonqGumby/transformationResultsHandler.test.ts Outdated Show resolved Hide resolved

dhasani23 reviewed

View reviewed changes

packages/amazonq/test/unit/amazonqGumby/transformationResultsHandler.test.ts Outdated Show resolved Hide resolved

dhasani23 reviewed

View reviewed changes

packages/core/src/amazonqGumby/chat/controller/messenger/messenger.ts Outdated Show resolved Hide resolved

dhasani23 reviewed

View reviewed changes

packages/core/src/codewhisperer/service/transformByQ/transformationResultsViewProvider.ts Outdated Show resolved Hide resolved

dhasani23 reviewed

View reviewed changes

packages/core/src/codewhisperer/service/transformByQ/transformationResultsViewProvider.ts Outdated Show resolved Hide resolved

dhasani23 reviewed

View reviewed changes

packages/core/src/codewhisperer/service/transformByQ/transformationResultsViewProvider.ts Outdated Show resolved Hide resolved

dhasani23 reviewed

View reviewed changes

packages/core/src/codewhisperer/service/transformByQ/transformationResultsViewProvider.ts Outdated Show resolved Hide resolved

dhasani23 reviewed

View reviewed changes

packages/core/src/codewhisperer/service/transformByQ/transformationResultsViewProvider.ts Outdated Show resolved Hide resolved

dhasani23 reviewed

View reviewed changes

packages/core/src/codewhisperer/service/transformByQ/transformationResultsViewProvider.ts Outdated Show resolved Hide resolved

dhasani23 reviewed

View reviewed changes

packages/core/src/codewhisperer/service/transformByQ/transformationResultsViewProvider.ts Outdated Show resolved Hide resolved

dhasani23 reviewed

View reviewed changes

packages/core/src/codewhisperer/service/transformByQ/transformationResultsViewProvider.ts Outdated Show resolved Hide resolved

dhasani23 reviewed

View reviewed changes

packages/amazonq/test/unit/amazonqGumby/transformationResultsHandler.test.ts Outdated Show resolved Hide resolved

dhasani23 reviewed

View reviewed changes

packages/amazonq/test/unit/amazonqGumby/transformationResultsHandler.test.ts Outdated Show resolved Hide resolved

ntarakad-aws force-pushed the selective_transform branch 3 times, most recently from 196539f to 2e253bf Compare

October 23, 2024 18:12

ntarakad-aws force-pushed the selective_transform branch from 2e253bf to b714214 Compare

October 29, 2024 16:03

ntarakad-aws changed the title ~~feat(amazon q): allow jdk17 as source, display multiple diff patches~~ feat(amazon q): display multiple diff patches

dhasani23 reviewed

View reviewed changes

packages/core/src/codewhisperer/service/transformByQ/transformationResultsViewProvider.ts Outdated Show resolved Hide resolved

dhasani23 reviewed

View reviewed changes

packages/core/src/amazonqGumby/chat/controller/controller.ts Outdated Show resolved Hide resolved

dhasani23 reviewed

View reviewed changes

packages/amazonq/package.json Outdated Show resolved Hide resolved

ntarakad-aws force-pushed the selective_transform branch from b714214 to 3ad9e0d Compare

November 1, 2024 23:53

github-actions bot commented Nov 1, 2024

This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
- Note: beta or "experiment" features that have active users should announce fixes in the changelog.
- If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

ntarakad-aws force-pushed the selective_transform branch from 3ad9e0d to b7c99c0 Compare

November 8, 2024 23:08

ntarakad-aws force-pushed the selective_transform branch from da35eed to 75d16a7 Compare

November 19, 2024 21:49

dhasani23 reviewed

View reviewed changes

packages/amazonq/.changes/next-release/Feature-735529a9-8424-4f78-9989-58ec972af100.json Outdated

Contributor

dhasani23 Nov 19, 2024

deleted changelog because we are going to merge this under a feature flag for now

ntarakad-aws force-pushed the selective_transform branch from 234639a to ee488f6 Compare

November 19, 2024 22:50

dhasani23 reviewed

View reviewed changes

packages/core/src/amazonqGumby/chat/controller/controller.ts

@@ @@ -401,6 +408,20 @@ export class GumbyController { @@
                           result: MetadataResult.Pass,
                       })
                       this.messenger.sendSkipTestsSelectionMessage(skipTestsSelection, message.tabID)
+                      if (!isSelectiveTransformationReady) {

Contributor

dhasani23 Nov 20, 2024

note: this is just a feature flag, waiting for our backend work to be ready, will merge with this flag until then

ntarakad-aws added 22 commits

November 19, 2024 16:15


          adding functionality to allow jdk17 as source and display multiple gi…

f04eb9c

…t patches for selective transformation


          addressing comments to add to models and minor edits

598ce08


          editing the clear changes and updating test file

6481abc


          editing test file to use models patchinfo

631d3f7


          fixing package files that we don't want in commit


          added test cases for new parseDiff logic

6cd90c2


          removing redundant unit test

693d4be


          updated tests to account for no diff.json and performed e2e transform…

f55cd36

…ation assuming current download artifact workflow


          added numbering to make it obvious to user which patch file they're v…

fb3436f

…iewing and updated chat messaging with start transformation prompt


          updated json structure based on backend and now collecting patchfiles…

bd8f324

… from json


          adding additional transformationFinished parameter

1f38262


          added patch description chat message and working on user input for on…

d4ef664

…e or multiple diffs


          added form to select one or multiple diffs and dynamically add to man…

88bba94

…ifest


          fixing java 11 messaging


          removed redudnant check for one or multiple diffs when accepting changes

d9ac6eb


          fixing tests and endpoint

c509beb


          addressing minor comments and fixing chat messaging

e63ab97


          fixing tests and addressing comments to remove redundancy

adda8af


          updating test import and adding changelog


          addressing comments from PR and adding feature flag

7b85bfb


          fixing failed unit tests

7a0f743


          updated test file

d6c2229

ntarakad-aws force-pushed the selective_transform branch from db8a720 to d6c2229 Compare

November 20, 2024 03:58

dhasani23 approved these changes

View reviewed changes

nkomonen-amazon reviewed

View reviewed changes

packages/amazonq/test/unit/amazonqGumby/transformationResultsHandler.test.ts

+                      const fileAmount = 1
+                      const workspaceFolder = await createTestWorkspace(fileAmount, { fileContent: '' })
+                      await fs.writeFile(

Contributor

nkomonen-amazon Nov 20, 2024

Our CI caught this block being duplicated, consider making a function like makeReadme(). This will not block the PR

nkomonen-amazon merged commit ac72bca into aws:master

23 of 25 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet